Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename unused vars to underscores #441

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

artek-koltun
Copy link
Collaborator

@artek-koltun artek-koltun commented Feb 12, 2024

fixing a new golangci-lint check
unblocks #440

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (86b40eb) 69.27% compared to head (8b4201c) 18.61%.

Files Patch % Lines
cmd/storage/test.go 0.00% 7 Missing ⚠️
cmd/network/evpn-bridge-port.go 0.00% 6 Missing ⚠️
cmd/storage/frontend/frontend.go 0.00% 6 Missing ⚠️
cmd/network/evpn-logical-brige.go 0.00% 5 Missing ⚠️
cmd/network/evpn-svi.go 0.00% 5 Missing ⚠️
cmd/network/evpn-vrf.go 0.00% 5 Missing ⚠️
cmd/storage/backend/backend.go 0.00% 4 Missing ⚠️
cmd/storage/backend/nvme_path.go 0.00% 4 Missing ⚠️
cmd/storage/frontend/nvme_controller.go 0.00% 4 Missing ⚠️
cmd/storage/storage.go 0.00% 3 Missing ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #441       +/-   ##
===========================================
- Coverage   69.27%   18.61%   -50.66%     
===========================================
  Files          18       62       +44     
  Lines        1393    10383     +8990     
===========================================
+ Hits          965     1933      +968     
- Misses        395     8191     +7796     
- Partials       33      259      +226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun marked this pull request as ready for review February 12, 2024 07:43
@artek-koltun artek-koltun requested a review from a team as a code owner February 12, 2024 07:43
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandersms sandersms merged commit 3e3e7eb into opiproject:main Feb 13, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants