Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Add Malloc Volume #450

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

moshe-shahar
Copy link
Contributor

Forked from backend_null.proto.
Add Malloc volume, volatile volume with metadata support.

@moshe-shahar moshe-shahar requested a review from a team as a code owner April 10, 2024 13:30
@moshe-shahar moshe-shahar force-pushed the moshe/backend_malloc branch from 5d2a88b to 653e3d4 Compare April 10, 2024 13:47
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my review

@glimchb glimchb requested a review from artek-koltun April 10, 2024 23:06
Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small notes

Forked from backend_null.proto.

Add Malloc volume, volatile volume with metadata support.

Signed-off-by: Moshe Shahar <mooshons@gmail.com>
Signed-off-by: Moshe Shahar <mooshons@gmail.com>
@moshe-shahar moshe-shahar force-pushed the moshe/backend_malloc branch from 653e3d4 to 327312d Compare April 14, 2024 07:30
@moshe-shahar
Copy link
Contributor Author

@artek-koltun , I addressed your comments. please review it again.

Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@artek-koltun artek-koltun merged commit bb755a5 into opiproject:main Apr 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants