-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ParseAuthorizedKey
instead of string parsing of the public key
#411
Conversation
Sorry for the title changes I borked up some stuff :D On second consideration, it might be better to keep the struct field I changed to type as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Xeckt for the contribution
This is exactly the direction I was looking for
Few small comments inside, once fixed, we can merge this PR
Thanks for the feedback! Will make the changes later today! |
All changes and feedback resolved. Let me know if the new changes are ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thansk @Xeckt for contributing and fixing all issues
please add copyright in the new file and fix few ci failures we good to merge
at this point you can also squash all commit into a single one, review is done
ParseAuthorizedKey
instead of string parsing of the public key
Linter issues fixed, ran |
Commits squashed! |
@Xeckt please note https://commitlint.js.org/ failing |
Gah! Sorry! |
no worries. just add |
Signed-off-by: Xeckt <jordansavell1198@gmail.com>
Should be done now |
Few changes in this pull request, more than anticipated:
ssh.PublicKey
Type()
func to get a keys exact type for thepublicKey
struct:ParseAuthorizedKey
func will detect if it's a valid key or notcreatetempfile
func for testing to be more inclusive of it's intention, moved the dhcp string for testing to a constant in thedaemon_test.go
fileI hope all these changes are okay. Let me know if you would like to change anything or revert any of the changes. All tests have passed locally, including daemon tests.