Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update linter action to v6 #445

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

h0lyalg0rithm
Copy link
Contributor

@h0lyalg0rithm h0lyalg0rithm commented Aug 3, 2024

Proposed changes

Upgrade linter action for better issue visibility.
The offending line shows up in the action run.

Sample output
https://github.com/h0lyalg0rithm/sztp/actions/runs/10222129019/job/28286107496

Types of changes

What types of changes does your code introduce to the repo? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@h0lyalg0rithm h0lyalg0rithm requested a review from a team as a code owner August 3, 2024 15:18
@@ -49,6 +49,6 @@
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v4
- uses: golangci/golangci-lint-action@v3
- uses: golangci/golangci-lint-action@v6

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 0: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
@h0lyalg0rithm h0lyalg0rithm force-pushed the upgrade_ci_golint branch 2 times, most recently from 828da86 to 55d39f2 Compare August 3, 2024 16:04
Signed-off-by: Suraj Shirvankar <surajshirvankar@gmail.com>
@glimchb glimchb merged commit 37d1977 into opiproject:main Aug 3, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants