-
Notifications
You must be signed in to change notification settings - Fork 148
✨initial implementation for Mask region selection. #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨initial implementation for Mask region selection. #23
Conversation
693f630
to
d766dd4
Compare
d766dd4
to
5eda734
Compare
8207b2a
to
6d295b9
Compare
6d295b9
to
03bf2ae
Compare
Is it possible for this to use a different lora per masked area? or do we still need to to combine this implementation with https://github.com/opparco/stable-diffusion-webui-composable-lora ? |
The feature I implemented has no conflict with the extension you mentioned. In fact it is functional at current state of this branch. |
I've got this: ImportError: cannot import name 'on_after_ui' from 'modules.script_callbacks' |
Take a look at README, |
Here's a demo of composable lora working, you use the same syntax as webui's built-in Lora extension. |
how i can install the extension on colab? |
Painting doesn't work on any browser - it's not gradio's fault since it works on controlnet |
Any reason to not open a PR in the webui repo for the callback patch included? This is getting shared around a lot with many not realizing it will not work out of the box. |
Tried in Chromium - crash |
I have the exact same thing on Firefox with the Sketch tab in A1111, so it does seem Gradio related. It is fixed when I load in an image from disk (in the case of the sketch tool, I have not tried this extension yet). |
Bug related to gradio Image component(the stuttering) has been fixed. For end users, please refer to the prerequisite section of README for instructions. Bugfix related modifications: |
fd0c1b4
to
c113858
Compare
c113858
to
1dfc95f
Compare
The bugfix didn't change anything - it's still as it was - you can't create a drawing canvas but you can load a graphic file and draw on it. |
Did you pull my latest commit and run pip install --force-reinstall --no-deps gradio-3.16.2-py3-none-any.whl in the folder? |
Dude, it worked perfectly for me. You basically just have to install the file gradio-3.16.2-py3-none-any.whl |
Yes also on fresh install |
Is there any error message in your console after the stuttering crashes the canvas? |
There are no errors displayed in the console. Only when trying "I've finished my sketch" and updating. Drawing at the beginning lags a lot and later it is not possible - the cursor disappears after hovering over the canvas. Drawing on the loaded image is possible. |
The official implementation of webui.sh created a venv, but you're not using it. |
Yes you are right |
yeah, I tried to use the same prompt but replaced the Lora you uesd in this example with some other Lora I got from civitai. Sadly it didn't works. Could you give me some help? |
It would be great if this could also generate ControlNet segmentation mask. |
Did you use one lora twice? opparco/stable-diffusion-webui-composable-lora#7 It seems okay when I use different loras but when I duplicate them, the image becomes corrupted. |
I'm sure I'm not using duplicate LORA when I generate this image, but I used 3 LORAs and 1 LoCon. |
Can you add a feature to save a masked image area? |
How and when would I do this when using a collab notebook? |
I now cant get a share link to launch WebUI. |
the style sheet included causes subfolders in the extra-networks area to be placed inconveniently to the center-left of the network-cards. |
Tried all the suggestions and the UI is still stuttering and unusable. Windows 11 with latest updates of everything. RTX 3090. |
this!!! thank you, I got that issue and could not find the culprit. |
Just remember to change it again when you update the extension, lol |
I doesn't know programming... |
What is blocking this to be merged into the main branch? |
@ashen-sensored The "Extra generation params" don't work as supposed. Generated images with your fork don't have the latent couple metadata. |
sketch window always freezes for me after making the blob masks, could be firefox I dont know. |
Dirty initial implementation.
