Skip to content

Commit

Permalink
Fix part of #5261: InefficientWeight (#5297)
Browse files Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fix part of #5261
(A) Added android:layout_width="0dp" to line 34 in
view_event_logs_event_log_item_view.xml

### Layout
Before:
<img width="316" alt="before"
src="https://github.com/oppia/oppia-android/assets/54560535/a37fba9a-d259-4eb3-b59e-b10d65f9ea57">


After:
<img width="321" alt="after"
src="https://github.com/oppia/oppia-android/assets/54560535/c67b01c3-aad7-4b51-9030-e483689c3914">


### Lint Check
Before: 
<img width="1415" alt="Screenshot 2024-01-20 at 14 14 24"
src="https://github.com/oppia/oppia-android/assets/54560535/ad82ff35-88e7-493b-b992-bced3d5ad777">

After:
<img width="1433" alt="Screenshot 2024-01-20 at 15 09 13"
src="https://github.com/oppia/oppia-android/assets/54560535/29c6122b-5d9f-498e-8531-e444c9d62a9f">



## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

---------

Co-authored-by: Adhiambo Peres <59600948+adhiamboperes@users.noreply.github.com>
  • Loading branch information
deonwaju and adhiamboperes authored Jan 28, 2024
1 parent 164f33b commit 60de5db
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<TextView
android:id="@+id/view_event_logs_time_text_view"
style="@style/Subtitle2ViewStart"
android:layout_width="0dp"
android:layout_weight="1"
android:background="@color/component_color_shared_item_background_solid_color"
android:paddingStart="16dp"
Expand Down

0 comments on commit 60de5db

Please sign in to comment.