Text unit is set in dp instead of sp

[JishnuGoyal]

Describe the bug

The text unit is dp instead sp which results in an accessibility error.

To Reproduce
Steps to reproduce the behavior:

1. On profiles page, click on add user profile option
2. Toolbar text has accessibility issue

Suggested Solution:
If you notice code of https://github.com/oppia/oppia-android/blob/da80fab4a78997cb8ab190292f0676117f2722fc/app/src/main/res/layout/admin_pin_activity.xml
we are not using any Toolbar in this xml file. Instead we are setting the title from

oppia-android/app/src/main/java/org/oppia/android/app/profile/AdminAuthActivityPresenter.kt

Line 119 in da80fab

resourceHandler.getStringInLocale(R.string.admin_auth_activity_add_profiles_title)

What we can do is that instead of using the toolbar/action-bar of activity we can introduce our own Toolbar in xml file and can use it in activity & its presenter to set the text. This way we can easily control sp vs dp metric.
Similar Implementation

Environment

• Device/emulator being used:
• Android or SDK version (e.g. Android 5 or SDK 21): Android 12
• App version (you can get this through system app settings or via the admin controls menu in-app): 0.10-beta-5e64fae55e

[BenHenning]

Android 12-specific issue, and one that has marginal benefits so considering it an a11y nice-to-have. Not release blocking.

[BenHenning]

Ah actually, this might not be 12-specific if the text itself is using the wrong unit. That being said, we just changed the way titles work back to the old flow so this may no longer be an issue.

[rt4914]

Ah actually, this might not be 12-specific if the text itself is using the wrong unit. That being said, we just changed the way titles work back to the old flow so this may no longer be an issue.

Just tested it and its still an issue and I have updated the issue description to mention one possible solution.

[Akshatkamboj14]

Hey @rt4914 when I am trying to add toolbar as proposed in the example, the system toolbar and my toolbar both are displayed simultaneously and plus when I am changing the title

oppia-android/app/src/main/java/org/oppia/android/app/profile/AdminAuthActivityPresenter.kt

Line 119 in da80fab

resourceHandler.getStringInLocale(R.string.admin_auth_activity_add_profiles_title)

to let's suppose something else it's not changing that even.

[rt4914]

@Akshatkamboj14 I cannot confirm the exact issue without the PR, but the main changes that you will need to apply in are the activity file, its corresponding xml file and may need to change AndroidManifest.xml file and may need to add android:theme="@style/OppiaThemeWithoutActionBar" to corresponding activity.

Also, I am a bit inactive these days, so please assign these issues to @MohitGupta121 or @BenHenning or any other active team-member for faster replies. Thanks.

[prafulbbandre]

Hi @adhiamboperes,
I would like to work on this issue.

[adityamishra9]

Hi @adhiamboperes , please allow me to work on this issue

[adhiamboperes]

Hi @void-iish, thanks for your interest in contributing to this issue, but it is already assigned to @prafulbbandre. Why don't you take a look at other unassigned issues here, and let me know which one interests you?

[Vishwajith-Shettigar]

can i work on this issue ?

[adhiamboperes]

can i work on this issue ?

@Vishwajith-Shettigar, we ask that you give us a brief description of how you would go about solving the issue, or otherwise put up a draft pull request.

[Vishwajith-Shettigar]

can i work on this issue ?

@Vishwajith-Shettigar, we ask that you give us a brief description of how you would go about solving the issue, or otherwise put up a draft pull request.

Here is my approach

1. Setting noActionbar for admin_pin_activity.
2. setting up own toolbar in admin_pin_activity.
3. using AdminPinActivityPresenter we can set the title

Can you tell me am I going right please, that would be really helpful.

[Vishwajith-Shettigar]

i have made a draft pull request #5132, please guide me.
Thank you

[Vishwajith-Shettigar]

Here is a new pull request #5134. Hope this works.