Fix #4735 Text unit is set in dp instead of sp

[Vishwajith-Shettigar]

Explanation

Fix #4735 , Added toolbar in admin_pin_activity xml file inorder to control the title size using sp.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Before fix
Admin pin activity

Light mode

After fix

Light mode	Dark mode

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[adhiamboperes]

I think that this is definitely a good approach.

The screenshots that you have shared don't seem to be from the accessibility scanner. Please refer to our wiki section on accessibility if you need help with that.

[oppiabot]

Hi @Vishwajith-Shettigar, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

[Vishwajith-Shettigar]

I think that this is definitely a good approach.

The screenshots that you have shared don't seem to be from the accessibility scanner. Please refer to our wiki section on accessibility if you need help with that.

Here is accessability scanner screenshot.

Android version 10
When I scanned, I have got no suggestions, please guide me if something is wrong here.

[Vishwajith-Shettigar]

Hey please tell is this issue android 12 specific, I haven't tried accessability Scanner with 12
Edit: Attached 12 also

[Vishwajith-Shettigar]

Android 12
Accessability scanner screenshot

[adhiamboperes]

Here is accessability scanner screenshot.

Android version 10 When I scanned, I have got no suggestions, please guide me if something is wrong here.

Basically;

1. You need to be able to verify that you can reproduce the issue. You can do this by switching to a branch like develop, deploying your app on that branch, then running the accessibility scanner for this screen. You should see the warnings same as in the issue description. (Save the screenshot, because you need to add it it to the description of this PR)
2. Next, switch back to your branch(that contains your fix), and deploy the app, test it with the accessibility scanner. essentially, if your fix works, all the warnings should be gone(no suggestions). You will also add this screenshot to the PR description for before/after proof.

[adhiamboperes]

Your changes have led to some failing tests, here is information on how to find what is broken, so you can update the code or tests as appropriate.

[Vishwajith-Shettigar]

Here is accessability scanner screenshot.
Android version 10 When I scanned, I have got no suggestions, please guide me if something is wrong here.

Basically;

1. You need to be able to verify that you can reproduce the issue. You can do this by switching to a branch like develop, deploying your app on that branch, then running the accessibility scanner for this screen. You should see the warnings same as in the issue description. (Save the screenshot, because you need to add it it to the description of this PR)
2. Next, switch back to your branch(that contains your fix), and deploy the app, test it with the accessibility scanner. essentially, if your fix works, all the warnings should be gone(no suggestions). You will also add this screenshot to the PR description for before/after proof.

Here is before fix

After fix

[adhiamboperes]

The screenshots look good. Thanks!

[adhiamboperes]

Hi @Vishwajith-Shettigar, once you are done making changes, please do the following:

• Go to the PR description and make sure you have done all the items on the Essential Checklist, and check them off
• Assign the PR to Ben Henning by mentioning him with "@(Ben Henning), PTAL".

[Vishwajith-Shettigar]

Hi @Vishwajith-Shettigar, once you are done making changes, please do the following:

• Go to the PR description and make sure you have done all the items on the Essential Checklist, and check them off
• Assign the PR to Ben Henning by mentioning him with "@(Ben Henning), PTAL".

hey actually I'm not able to understand why my checks are failing, can you give some idea about this please, that would be very helpful. @BenHenning

[oppiabot]

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

[Vishwajith-Shettigar]

Can you guide me why some checks are failing please ?

[adhiamboperes]

I have left one nit comment - and for complete approval please update your PR description to include the following:

• An explanation of the changes that you have made
• Before(build using develop branch) and after screenshots(build app using your branch) of accessibility scanner showing that the warning is shown before your fix and gone after the fix. You can look at table formatting in markdown to organize your screenshots. Please see this for example.

[Vishwajith-Shettigar]

I have made some changes PTAL, thank you.

[adhiamboperes]

I have made some changes PTAL, thank you.

Thanks. Do you know why the lightmode screenshot of the "after" fix is showing new suggestions?

[Vishwajith-Shettigar]

I have made some changes PTAL, thank you.

Thanks. Do you know why the lightmode screenshot of the "after" fix is showing new suggestions?

no, I dont have any idea about that.

[adhiamboperes]

I have made some changes PTAL, thank you.

Thanks. Do you know why the lightmode screenshot of the "after" fix is showing new suggestions?

no, I dont have any idea about that.

Well, could you please share the suggestions?

[Vishwajith-Shettigar]

I have made some changes PTAL, thank you.

Thanks. Do you know why the lightmode screenshot of the "after" fix is showing new suggestions?

no, I dont have any idea about that.

Well, could you please share the suggestions?

seems like its about background and foreground contrast ratio.

[Vishwajith-Shettigar]

I switched to develop branch,now it shows same with light mode (api 31)

[seanlip]

LGTM for 1 codeowner file

[adhiamboperes]

I switched to develop branch,now it shows same with light mode (api 31)

I checked this and the issue appears on the beta version as well. I don't think that should block this PR since the toolbar issue is fixed.

@Vishwajith-Shettigar, do you mind creating a bug report for the contrast issue?

@BenHenning, PTAL.

[Vishwajith-Shettigar]

I switched to develop branch,now it shows same with light mode (api 31)

I checked this and the issue appears on the beta version as well. I don't think that should block this PR since the toolbar issue is fixed.

@Vishwajith-Shettigar, do you mind creating a bug report for the contrast issue?

@BenHenning, PTAL.

@adhiamboperes Sure, thank you.

[oppiabot]

Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks!

[oppiabot]

Unassigning @adhiamboperes since they have already approved the PR.

[adhiamboperes]

Merging this since a seperate issue #5142 has been created for the edit text contrasts.