Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wiki documentation for dark-mode #5016

Closed
3 tasks
MohitGupta121 opened this issue Jun 5, 2023 · 1 comment · Fixed by #5097
Closed
3 tasks

Add wiki documentation for dark-mode #5016

MohitGupta121 opened this issue Jun 5, 2023 · 1 comment · Fixed by #5097
Assignees
@rt4914
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: High It's not clear what the solution is.

Comments

@MohitGupta121
Copy link
Member

MohitGupta121 commented Jun 5, 2023 •
edited by seanlip
Loading

Is your feature request related to a problem? Please describe.
Now we have dark-mode support in oppia-android but we need proper documentation for Desginers, Developers and also for Reviewer's so that they can follow proper guide for dark-mode feature or bug fix.

Describe the solution you'd like
Add wiki documentation for dark-mode:

  • Designers Guide
  • Developer related dark mode documentation is required :
    • How to edit existing screens / colors?
    • How to implement new screens?
  • Reviewer's guide
    • Note: Developers must include at least 1 screenshot of dark mode when asking for PR review. Reviewers need to check that this is provided and that it looks OK.
@MohitGupta121
Copy link
Member Author

A11Y scanner recording of Dark-Mode - Link

@MohitGupta121 MohitGupta121 added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). enhancement End user-perceivable enhancements. Work: High It's not clear what the solution is. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Jun 8, 2023
@seanlip seanlip removed the Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. label Jun 18, 2023
@rt4914 rt4914 mentioned this issue Aug 1, 2023
Merged
6 tasks
seanlip pushed a commit that referenced this issue Aug 2, 2023
@rt4914
Fix #5016: Dark mode wiki update (#5097)
2b3213c 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

This PR adds more information to Dark-Mode wiki page.

Fix #5016: Dark mode wiki update

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: High It's not clear what the solution is.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5016: Dark mode wiki update oppia/oppia-android
3 participants
@rt4914 @seanlip @MohitGupta121