Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5016: Dark mode wiki update #5097

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Fix #5016: Dark mode wiki update #5097

merged 5 commits into from
Aug 2, 2023

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 19, 2023

Explanation

This PR adds more information to Dark-Mode wiki page.

Fix #5016: Dark mode wiki update

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@rt4914
Copy link
Contributor Author

rt4914 commented Jul 19, 2023

@seanlip @MohitGupta121 I have updated the Dark-mode wiki in this PR. Please have a look and suggest changes. Thanks.

Copy link
Member

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 PTAL few doubts, we do not need to specify that the color-def always uses the color from color-hex.
Thanks!

wiki/Dark-Mode.md Outdated Show resolved Hide resolved
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914! Took a pass, left some comments. PTAL.

wiki/Dark-Mode.md Outdated Show resolved Hide resolved
wiki/Dark-Mode.md Outdated Show resolved Hide resolved
wiki/Dark-Mode.md Outdated Show resolved Hide resolved
wiki/Dark-Mode.md Outdated Show resolved Hide resolved
wiki/Dark-Mode.md Outdated Show resolved Hide resolved
@seanlip seanlip removed their assignment Jul 21, 2023
@oppiabot
Copy link

oppiabot bot commented Jul 28, 2023

Hi @rt4914, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 28, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 1, 2023
@rt4914 rt4914 changed the title Dark mode wiki update Fix #5016: Dark mode wiki update Aug 1, 2023
@rt4914 rt4914 assigned seanlip and MohitGupta121 and unassigned rt4914 Aug 1, 2023
@MohitGupta121 MohitGupta121 self-requested a review August 1, 2023 13:32
@oppiabot
Copy link

oppiabot bot commented Aug 1, 2023

Unassigning @MohitGupta121 since they have already approved the PR.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 Took another pass, PTAL. Thanks!

wiki/Dark-Mode.md Outdated Show resolved Hide resolved
wiki/Dark-Mode.md Outdated Show resolved Hide resolved
wiki/Dark-Mode.md Outdated Show resolved Hide resolved
wiki/Dark-Mode.md Outdated Show resolved Hide resolved
@seanlip seanlip removed their assignment Aug 1, 2023
@rt4914 rt4914 assigned seanlip and unassigned rt4914 Aug 1, 2023
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914!

@seanlip seanlip enabled auto-merge (squash) August 2, 2023 17:36
@seanlip
Copy link
Member

seanlip commented Aug 2, 2023

@rt4914 I clicked all the approve buttons but I'm not sure why it's not merging. I think you might need to merge develop into your branch, could you please do that?

Thanks!

@seanlip seanlip assigned rt4914 and unassigned seanlip Aug 2, 2023
@oppiabot oppiabot bot added the PR: LGTM label Aug 2, 2023
@oppiabot
Copy link

oppiabot bot commented Aug 2, 2023

Hi @rt4914, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@MohitGupta121
Copy link
Member

@rt4914 I clicked all the approve buttons but I'm not sure why it's not merging. I think you might need to merge develop into your branch, could you please do that?

@seanlip I think you also do it by clicking on "Update Branch"?

Screenshot 2023-08-02 at 11 48 52 AM

@seanlip seanlip merged commit 2b3213c into develop Aug 2, 2023
25 checks passed
@seanlip seanlip deleted the dark-mode-wiki-update branch August 2, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wiki documentation for dark-mode
3 participants