Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add wiki documentation for how to pick the emulator/android version when running Espresso tests. #5062

Closed
seanlip opened this issue Jun 18, 2023 · 0 comments · Fixed by #5174
Assignees
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@seanlip
Copy link
Member

seanlip commented Jun 18, 2023

Is your feature request related to a problem? Please describe.
Developers aren't sure whether there is a recommended setup for choosing the emulator + Android version when running Espresso tests. See #4868 (comment).

@BenHenning provided a response here and suggested providing wiki instructions for how to pick an API/form-factor combination. This issue tracks that.

Describe the solution you'd like
The wiki page should have clear instructions on what setup to pick. It should provide a prescriptive path (that new contributors can use without further investigation) and list other potential options that would be valid as well.

This could perhaps go in the wiki page on testing, or possibly be part of the instructions on "how to make your PR". They should be part of an explanation of the steps that contributors need to take in order to run those tests.

Describe alternatives you've considered
N/A

Additional context
N/A

@seanlip seanlip added the enhancement End user-perceivable enhancements. label Jun 18, 2023
@MohitGupta121 MohitGupta121 added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Jun 26, 2023
@adhiamboperes adhiamboperes self-assigned this Oct 3, 2023
adhiamboperes added a commit that referenced this issue Oct 9, 2023
…ntation (#5174)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fix #5073:  Add instructions to the wiki for how to assign a reviewer.
Fix #5062:  Add wiki documentation for how to pick the emulator/android
version when running Espresso tests.
Fix #5099:  Reorganize the Project Setup Documentation
Fix part of #1723: ensure the onboarding flow leads into follow-up
documentation: architecture overview, code style, submission guidelines,
how to make UX changes, how to contribute large projects (which should
tie into design documents), and best practices
Fix part of #1723: Known issues that have come up in discussions

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Development

Successfully merging a pull request may close this issue.

3 participants