Fix #5073, #5062, #5099, and part of #1723: Improve Onboarding Documentation #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make steps more linear - Include information that address common setup issues - Add information about running tests
|
@MohitGupta121, could you PTAL and let me know your thoughts? |
There was a problem hiding this comment.
@adhiamboperes LGTM, Thanks!
Very clear and to the point instructions now.
MohitGupta121
approved these changes
Oct 6, 2023
|
Assigning @BenHenning for code owner reviews. Thanks! |
|
@seanlip, PTAL for codeowners, (If possible). |
|
Unassigning @adhiamboperes since a re-review was requested. @adhiamboperes, please make sure you have addressed all review comments. Thanks! |
seanlip
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Thanks @adhiamboperes! LGTM. You might need to fix the sidebar merge conflict though.
adhiamboperes
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix #5073: Add instructions to the wiki for how to assign a reviewer.
Fix #5062: Add wiki documentation for how to pick the emulator/android version when running Espresso tests.
Fix #5099: Reorganize the Project Setup Documentation
Fix part of #1723: ensure the onboarding flow leads into follow-up documentation: architecture overview, code style, submission guidelines, how to make UX changes, how to contribute large projects (which should tie into design documents), and best practices
Fix part of #1723: Known issues that have come up in discussions
Essential Checklist