Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5075: Exempt Existing Vectors from ColorHex Checks #5123

Merged
merged 7 commits into from
Sep 19, 2023

Conversation

adhiamboperes
Copy link
Collaborator

@adhiamboperes adhiamboperes commented Aug 7, 2023

Explanation

Fixes #5075.
This PR adds back the color hex regex check removed in #5076. This requires a static check exemption for two vectors in the drawable directory, survey_nps_radio_selected_color.xml and survey_nps_radio_unselected_color.xml.

The check file_path_regex: "app/src/main/res/drawable.*?/.+?\\.xml" blanket checks all drawables, including vectors. Since these cannot fully be changed to use component colors yet, I think that the best approach is to exempt them from the check.

This is a replacement of PR #5081, since #5081 would nolonger be a clean revert.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@adhiamboperes adhiamboperes changed the base branch from develop to revert-5076-ci_checks_fail August 7, 2023 04:48
@adhiamboperes adhiamboperes self-assigned this Aug 7, 2023
@adhiamboperes adhiamboperes changed the base branch from revert-5076-ci_checks_fail to develop August 10, 2023 14:00
@adhiamboperes adhiamboperes changed the title Fix Part of #5075: Exempt Existing Vectors from ColorHex Checks Fix #5075: Exempt Existing Vectors from ColorHex Checks Aug 10, 2023
@adhiamboperes adhiamboperes marked this pull request as ready for review August 10, 2023 14:14
@adhiamboperes adhiamboperes requested review from a team as code owners August 10, 2023 14:14
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adhiamboperes! Took a pass and left a couple of follow-ups--PTAL.

@oppiabot
Copy link

oppiabot bot commented Aug 24, 2023

Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 24, 2023
@oppiabot oppiabot bot closed this Aug 31, 2023
@adhiamboperes adhiamboperes reopened this Sep 15, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 15, 2023
…rom-checks

# Conflicts:
#	app/src/main/res/values-night/color_palette.xml
#	app/src/main/res/values/color_palette.xml
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adhiamboperes! LGTM.

@BenHenning BenHenning enabled auto-merge (squash) September 19, 2023 19:53
@BenHenning
Copy link
Sponsor Member

Enabling auto-merge since there are no outstanding comments to address.

@oppiabot
Copy link

oppiabot bot commented Sep 19, 2023

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Sep 19, 2023
@oppiabot
Copy link

oppiabot bot commented Sep 19, 2023

Hi @adhiamboperes, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit c28b8ee into develop Sep 19, 2023
24 of 25 checks passed
@BenHenning BenHenning deleted the exempt-vectors-from-checks branch September 19, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Regex Check That Prohibits ColorHex Usage in Drawables Post Kitkat
2 participants