-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5075: Exempt Existing Vectors from ColorHex Checks #5123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adhiamboperes! Took a pass and left a couple of follow-ups--PTAL.
scripts/src/javatests/org/oppia/android/scripts/regex/RegexPatternValidationCheckTest.kt
Show resolved
Hide resolved
…vectors-from-checks
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
…rom-checks # Conflicts: # app/src/main/res/values-night/color_palette.xml # app/src/main/res/values/color_palette.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adhiamboperes! LGTM.
Enabling auto-merge since there are no outstanding comments to address. |
Unassigning @BenHenning since they have already approved the PR. |
Hi @adhiamboperes, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes #5075.
This PR adds back the color hex regex check removed in #5076. This requires a static check exemption for two vectors in the
drawable
directory,survey_nps_radio_selected_color.xml
andsurvey_nps_radio_unselected_color.xml
.The check
file_path_regex: "app/src/main/res/drawable.*?/.+?\\.xml"
blanket checks all drawables, including vectors. Since these cannot fully be changed to use component colors yet, I think that the best approach is to exempt them from the check.This is a replacement of PR #5081, since #5081 would nolonger be a clean revert.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: