Fix #3930 Greeting text on home screen should be a single TextView

[ShubhadeepKarmakar]

Explanation

• Fix Greeting text on home screen should be a single TextView #3930

Removes profile_name_text_view and combines the greeting text and profile name using one string template, welcome_profile_name in WelcomeViewModel.computeWelcomeText()

In the testHomeActivity_initialArabicContext_displaysStringsInArabic test, unicode characters \u200F\u202A...\u202C\u200F! are introduced to allow bidirectional reading.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)

RTL:

LTR:

[ShubhadeepKarmakar]

@adhiamboperes am I going the right way?

[adhiamboperes]

Thanks @ShubhadeepKarmakar!

I have left some comments inline.

Here is a resource on Localization in android thet might help.

[ShubhadeepKarmakar]

Now just need to customize corresponding tests?

[adhiamboperes]

Now just need to customize corresponding tests?

Yes please, make sure the tests pass.

Also please address, in your PR description, the concerns raised in the issue description regarding LTR and the underline text.

[ShubhadeepKarmakar]

@adhiamboperes please check it.

[adhiamboperes]

Thanks @ShubhadeepKarmakar!

I have one comment to help fix your failing test.

Once all your CI checks pass, please assign this PR to Ben by @ mentioning him with "(@)Ben Henning, PTAL".

[ShubhadeepKarmakar]

@adhiamboperes can you help me to get out of these 4 failed checks?

[MohitGupta121]

@ShubhadeepKarmakar actually your one of the Robolectric test is failing as String in Arabic is not matching with exact text. You have to change the text as per the log excepted here in this test.

For more details go through this wiki

[ShubhadeepKarmakar]

@MohitGupta121 thanks but still two checks failed.

[oppiabot]

Hi @ShubhadeepKarmakar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[adhiamboperes]

Hi @ShubhadeepKarmakar, please let me know if you need any further assistance with this PR.

[oppiabot]

Hi @ShubhadeepKarmakar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[adhiamboperes]

@ShubhadeepKarmakar please re-assign this PR to me once you have addressed all the comments.

[ShubhadeepKarmakar]

Hi @ShubhadeepKarmakar, please let me know if you need any further assistance with this PR.

Then there will be no space between greeting and profile name.

[adhiamboperes]

Hi @ShubhadeepKarmakar, please let me know if you need any further assistance with this PR.

Then there will be no space between greeting and profile name.

There will be, if you put a space between the two %s in the template. Have you tried the solution?

[ShubhadeepKarmakar]

Hi @ShubhadeepKarmakar, please let me know if you need any further assistance with this PR.

Then there will be no space between greeting and profile name.

There will be, if you put a space between the two %s in the template. Have you tried the solution?

Thanks @adhiamboperes. Sorry it was my fault, I changed the welcome() function like you said.

[adhiamboperes]

Thanks @ShubhadeepKarmakar, LGTM.

[oppiabot]

Assigning @BenHenning for code owner reviews. Thanks!

[oppiabot]

Hi @ShubhadeepKarmakar, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!