Fix #5187 Textview contrast issue in locked lesson #5189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adhiamboperes, PTAL |
Vishwajith-Shettigar
changed the title
adhiamboperes
assigned MohitGupta121 and unassigned adhiamboperes and Vishwajith-Shettigar
|
@MohitGupta121, could you please take a look and let me know if @Vishwajith-Shettigar has made appropriate changes per darkmode guidelines? |
MohitGupta121
requested changes
Oct 17, 2023
There was a problem hiding this comment.
@Vishwajith-Shettigar Thanks for PR, as I observed there is some inconsistency with background color of text and lock, so I recommend to keep the color of both lock background and text same for dark mode.
And let see that passing the accessibility scan.
@adhiamboperes what your suggestion on this inconsistency?
|
Unassigning @MohitGupta121 since the review is done. |
|
Hi @Vishwajith-Shettigar, it looks like some changes were requested on this pull request by @MohitGupta121. PTAL. Thanks! |
|
@MohitGupta121, PTAL.
|
|
Unassigning @Vishwajith-Shettigar since a re-review was requested. @Vishwajith-Shettigar, please make sure you have addressed all review comments. Thanks! |
MohitGupta121
approved these changes
Oct 17, 2023
adhiamboperes
approved these changes
Oct 18, 2023
Rd4dev
pushed a commit
to Rd4dev/oppia-android
that referenced
this pull request
Oct 31, 2023
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> Fixes oppia#5187, changing the background color of the locked lessons' TextView fixed the contrast ratio issue. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only Before Fix | Light Mode| Dark Mode| |--------|--------| | || After Fix | Light Mode| Dark Mode| |--------|--------| | || <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #5187, changing the background color of the locked lessons' TextView fixed the contrast ratio issue.
Essential Checklist
For UI-specific PRs only
Before Fix
After Fix
If your PR includes UI-related changes, then: