Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5204 - Inconsistent Layout Lint Warning #5217

Closed
wants to merge 3 commits into from

Conversation

Rd4dev
Copy link
Collaborator

@Rd4dev Rd4dev commented Oct 31, 2023

Explanation

Fix #5204 - [Part of #5169]

To address the lint warnings, two potential solutions were considered.

  1. Initially, there was an option to include the missing IDs, ensuring consistency across different layout configurations [Link]. However, it was observed that implementing this solution led to functional disruptions within the current working application, as confirmed through comprehensive testing procedures (refer to the attached assets for a detailed overview).
Adding.missing.id.mp4
  1. The second option was to suppress the lint warnings for the specific views in the layout-sw600dp configuration files [Link] to maintain the seamless functionality of the application . This was achieved by incorporating the attribute tools:ignore="InconsistentLayout" for relevant views, without impacting the current operational stability of the application.
ignore.inconsistent.layout.mp4

Taking the necessary action, I proceeded to implement the suppression of lint warnings by submitting a pull request.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@Rd4dev Rd4dev requested review from a team as code owners October 31, 2023 11:37
@Rd4dev Rd4dev force-pushed the Issue#5169-InconsistentLayout branch from 22e189e to a0f5b1e Compare October 31, 2023 11:42
@adhiamboperes
Copy link
Collaborator

@Rd4dev, it seems that you have rebased this PR, which we do not allow per (wiki). You need to open a replacement PR and close this one.

When syncing your branch with develop, always use merge instead of rebase.

Ensure you assign me once done.

@Rd4dev
Copy link
Collaborator Author

Rd4dev commented Oct 31, 2023

❌ closing this PR as rebase is not encouraged.

@Rd4dev Rd4dev closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InconsistentLayout Lint Warning
2 participants