Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5231: "Implied quantity lint warning in pt-rBR strings" #5259

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

deonwaju
Copy link
Collaborator

@deonwaju deonwaju commented Dec 4, 2023

Explanation

Fix #5231

  1. Replaced quantity "one" with %s at warnings of implied quantity in pt-rBR strings.
  2. Removed new line formats.
Screenshot 2023-12-04 at 21 22 46

Before
Screenshot 2023-12-04 at 20 50 19

After
Screenshot 2023-12-04 at 20 50 29

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@deonwaju deonwaju requested a review from a team as a code owner December 4, 2023 20:32
@deonwaju
Copy link
Collaborator Author

deonwaju commented Dec 4, 2023

Hello @adhiamboperes, I have added the fixes, but i need help with the ci errors.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deonwaju, I have shared the failing test inline. To learn how to intepret CI results, please refer to this page on the wiki and let me know if I can clarify anything.

app/src/main/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved
Copy link

oppiabot bot commented Dec 4, 2023

Hi @deonwaju, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@deonwaju
Copy link
Collaborator Author

deonwaju commented Dec 4, 2023

@adhiamboperes PTAL

@oppiabot oppiabot bot assigned adhiamboperes and unassigned deonwaju Dec 4, 2023
Copy link

oppiabot bot commented Dec 4, 2023

Unassigning @deonwaju since a re-review was requested. @deonwaju, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @deonwaju!

@adhiamboperes adhiamboperes merged commit bee2b58 into oppia:develop Dec 5, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix "ImpliedQuantity" lint warning in pt-rBR strings.
2 participants