Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5015: Added CI to oppia-android wiki (check toc) #5382
base: develop
Are you sure you want to change the base?
Fix #5015: Added CI to oppia-android wiki (check toc) #5382
Changes from 16 commits
13efcfa
d3795b3
1840f60
9fdea36
d113747
39f0c2f
d55ddac
49917c7
94fa4f6
3e74a99
5a8b4b9
9e4386a
9193d15
620c3b0
99c0371
72d0a2b
b5c9cf3
fab6c2e
afaf59e
6dfa3bb
be00151
c18ac91
2dfd045
c7d0d11
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might we, instead, want to ban emojis? It would reduce the maintainance burden. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two thoughts on this but I'm unsure of the right approach:
:emoji:
form for comparison and validation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't emojis fail by default since their presence would cause a mismatch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it. I thought we should implement something to restrict adding emojis separately while pushing. In that case, the current check could work in both ways - by checking the TOC and also by allowing contributors to add emojis (if needed) but in a certain pattern.
(:emoji:)
[:otter:], the headers should include it. - [This is an option if contributors want to represent them in both headers and the TOC representation]Few examples that would work are:
Table of Contents
Headers
So, anything in the wrong format would be checked by the script, and contributors can decide how they want to represent it, I guess.