Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #5344: Fix Localization Issues of Classroom List Screen #5479

Merged
merged 28 commits into from
Aug 8, 2024

Conversation

theMr17
Copy link
Collaborator

@theMr17 theMr17 commented Aug 7, 2024

Explanation

Fixes part of #5344

This PR fixes the localization issues of the promoted stories' header and the classroom carousel.

Screenshots

Portrait Landscape
image image
image image

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@theMr17 theMr17 self-assigned this Aug 7, 2024
@theMr17 theMr17 requested a review from a team as a code owner August 7, 2024 13:02
@theMr17 theMr17 requested review from adhiamboperes and removed request for a team August 7, 2024 13:02
@theMr17
Copy link
Collaborator Author

theMr17 commented Aug 8, 2024

Hi @adhiamboperes, I've created this PR to fix the RTL layout issues. Could you please take a look at the latest screenshots and let me know if any further changes are required?

@theMr17 theMr17 assigned adhiamboperes and unassigned theMr17 Aug 8, 2024
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @theMr17!

@oppiabot oppiabot bot added the PR: LGTM label Aug 8, 2024
Copy link

oppiabot bot commented Aug 8, 2024

Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

Base automatically changed from multiple-classrooms-refactor-ui to develop August 8, 2024 12:21
@adhiamboperes adhiamboperes requested a review from a team as a code owner August 8, 2024 12:21
@adhiamboperes adhiamboperes changed the title Fix part of #5344: Fix Accessibility Issues of Classroom List Screen Fix part of #5344: Fix Localization Issues of Classroom List Screen Aug 8, 2024
@adhiamboperes
Copy link
Collaborator

@theMr17, please sync branch and resolve conflicts.

@theMr17
Copy link
Collaborator Author

theMr17 commented Aug 8, 2024

@theMr17, please sync branch and resolve conflicts.

Done @adhiamboperes!

@theMr17 theMr17 assigned adhiamboperes and unassigned theMr17 Aug 8, 2024
@adhiamboperes adhiamboperes enabled auto-merge (squash) August 8, 2024 17:23
@adhiamboperes adhiamboperes merged commit 83f5356 into develop Aug 8, 2024
36 checks passed
@adhiamboperes adhiamboperes deleted the multiple-classrooms-accessibility branch August 8, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants