-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1468: Retain Drag and Drop state after an incorrect answer #5541
base: develop
Are you sure you want to change the base?
Fix #1468: Retain Drag and Drop state after an incorrect answer #5541
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 46375af - Browse repository at this point
Copy the full SHA 46375afView commit details -
Yet to figure out if runBlocking is the suitable approach and then continue with figuring out the tests
Configuration menu - View commit details
-
Copy full SHA for 541c0ae - Browse repository at this point
Copy the full SHA 541c0aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0307892 - Browse repository at this point
Copy the full SHA 0307892View commit details
Commits on Sep 28, 2024
-
Updating the UI via live data - reset works; the empty input error re…
…cognition fails The implementation changes the initial value, so the original value is not equal to the or will never be equal to the choice items (other than the actual original reordering) since it is continuing from the retain state. So either this is the way to go or should figure out a way to set original item as retained value (which I doubt if could be properly synced as it is asynchronous and the first return is a empty list).
Configuration menu - View commit details
-
Copy full SHA for a09bbf4 - Browse repository at this point
Copy the full SHA a09bbf4View commit details -
Updated the original choice items with a new instance of the choice I…
…tems This works well to check for the get Submit Time Error checks with the updated ephemeral state value as needed now the only step I is to make sure the _choiceItems is handled properly and also doubt if originalItems would even need any separate functionality.
Configuration menu - View commit details
-
Copy full SHA for 8e093cd - Browse repository at this point
Copy the full SHA 8e093cdView commit details -
Initializing the _choiceItems to a empty list to never have a null re…
…ference The original choice item list would be still required as it is required as a fallback value for the _choiceItems. Running the tests resulted in 2 failures and they need to be addressed.
Configuration menu - View commit details
-
Copy full SHA for 090c244 - Browse repository at this point
Copy the full SHA 090c244View commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 94e86f4 - Browse repository at this point
Copy the full SHA 94e86f4View commit details -
Temporary Fix to handle grouping - resets (does not retain)
A way to handle the grouping of elements with the wrongAnswerList is yet to be handled. Since choiceString points to the original size and list it does not align with the wrongAnswerList and also the wrongAnswerList and updateList would need a different handling - (to be figured out)
Configuration menu - View commit details
-
Copy full SHA for 43a73e8 - Browse repository at this point
Copy the full SHA 43a73e8View commit details -
Implementation of a retaining the reordered state with linking / grou…
…ping Needs a refactoring to combine them as one conditional return list and also to check the updation of the list on each drag end (doesn't occur with unlinkable elements).
Configuration menu - View commit details
-
Copy full SHA for 58ef353 - Browse repository at this point
Copy the full SHA 58ef353View commit details -
Refactored the result retrieval with wrongAnswerList and added Robole…
…ctric test cases for merge and unlink drag drop elements
Configuration menu - View commit details
-
Copy full SHA for f761445 - Browse repository at this point
Copy the full SHA f761445View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa4f2de - Browse repository at this point
Copy the full SHA aa4f2deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d1ab3a - Browse repository at this point
Copy the full SHA 7d1ab3aView commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 41f1195 - Browse repository at this point
Copy the full SHA 41f1195View commit details
Commits on Oct 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2989b1a - Browse repository at this point
Copy the full SHA 2989b1aView commit details
Commits on Oct 2, 2024
-
Using the original choice items as a fall back value if the async res…
…ult fails to retrieve data, making sure the original data is displayed instead of a empty list
Configuration menu - View commit details
-
Copy full SHA for 83349ef - Browse repository at this point
Copy the full SHA 83349efView commit details