Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1468: Retain Drag and Drop state after an incorrect answer #5541

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Commits on Sep 22, 2024

  1. Configuration menu
    Copy the full SHA
    46375af View commit details
    Browse the repository at this point in the history
  2. Removed unused import

    Yet to figure out if runBlocking is the suitable approach and then continue with figuring out the tests
    Rd4dev committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    541c0ae View commit details
    Browse the repository at this point in the history
  3. Fix Ktlint issues

    Rd4dev committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    0307892 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Updating the UI via live data - reset works; the empty input error re…

    …cognition fails
    
    The implementation changes the initial value, so the original value is not equal to the or will never be equal to the choice items (other than the actual original reordering) since it is continuing from the retain state. So either this is the way to go or should figure out a way to set original item as retained value (which I doubt if could be properly synced as it is asynchronous and the first return is a empty list).
    Rd4dev committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    a09bbf4 View commit details
    Browse the repository at this point in the history
  2. Updated the original choice items with a new instance of the choice I…

    …tems
    
    This works well to check for the get Submit Time Error checks with the updated ephemeral state value as needed now the only step I is to make sure the _choiceItems is handled properly and also doubt if originalItems would even need any separate functionality.
    Rd4dev committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    8e093cd View commit details
    Browse the repository at this point in the history
  3. Initializing the _choiceItems to a empty list to never have a null re…

    …ference
    
    The original choice item list would be still required as it is required as a fallback value for the _choiceItems. Running the tests resulted in 2 failures and they need to be addressed.
    Rd4dev committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    090c244 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Configuration menu
    Copy the full SHA
    94e86f4 View commit details
    Browse the repository at this point in the history
  2. Temporary Fix to handle grouping - resets (does not retain)

    A way to handle the grouping of elements with the wrongAnswerList is yet to be handled. Since choiceString points to the original size and list it does not align with the wrongAnswerList and also the wrongAnswerList and updateList would need a different handling - (to be figured out)
    Rd4dev committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    43a73e8 View commit details
    Browse the repository at this point in the history
  3. Implementation of a retaining the reordered state with linking / grou…

    …ping
    
    Needs a refactoring to combine them as one conditional return list and also to check the updation of the list on each drag end (doesn't occur with unlinkable elements).
    Rd4dev committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    58ef353 View commit details
    Browse the repository at this point in the history
  4. Refactored the result retrieval with wrongAnswerList and added Robole…

    …ctric test cases for merge and unlink drag drop elements
    Rd4dev committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f761445 View commit details
    Browse the repository at this point in the history
  5. Ktlint indentation fix

    Rd4dev committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    aa4f2de View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7d1ab3a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Configuration menu
    Copy the full SHA
    41f1195 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    2989b1a View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Using the original choice items as a fall back value if the async res…

    …ult fails to retrieve data, making sure the original data is displayed instead of a empty list
    Rd4dev committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    83349ef View commit details
    Browse the repository at this point in the history