forked from typetools/checker-framework
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downcast to CF #213
Closed
Closed
Add downcast to CF #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewShf
commented
Jun 15, 2022
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Show resolved
Hide resolved
wmdietl
pushed a commit
that referenced
this pull request
Jun 19, 2022
AndrewShf
commented
Jun 22, 2022
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
AndrewShf
commented
Jun 23, 2022
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Show resolved
Hide resolved
AndrewShf
commented
Jun 23, 2022
AndrewShf
commented
Jun 23, 2022
AndrewShf
commented
Jun 23, 2022
AndrewShf
commented
Jun 24, 2022
framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
Outdated
Show resolved
Hide resolved
AndrewShf
commented
Jun 25, 2022
checker-util/src/main/java/org/checkerframework/checker/nullness/util/NullnessUtil.java
Outdated
Show resolved
Hide resolved
@wmdietl Hi Prof, this PR is ready for review. |
Reopened this PR in eisop repo eisop#337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumerate all the conditions:
Main logic:
method isUpcast(...) logic:
isSafeDowncast logic:
isSafeIncomparableCast() logic: