Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file watching doesn't work #156

Open
samuelstroschein opened this issue Mar 2, 2025 — with Linear · 4 comments
Open

file watching doesn't work #156

samuelstroschein opened this issue Mar 2, 2025 — with Linear · 4 comments
Assignees

Comments

Copy link
Member

samuelstroschein commented Mar 2, 2025

Context

From Discord

20250302-0100-01.8730684.mp4

Proposal

Fix/implement file watching.

Additional information

  • paraglide js uses this code to determine which files have been read when importing
  • sherlock would need to set up chokidar or similar to watch the read files, upon a change execute importFiles again
  • this file watching API is not part of the inlang SDK because node and file system dependencies are not suppose to be in the SDK, and loading projects from a directory (instead of files) is an interim workaround
@ubistrul
Copy link

ubistrul commented Mar 2, 2025

👀

Sherlock version = 2.0.0-2.0.4

OS: Win11,
VS Code version: 1.97.0

Copy link
Contributor

I'll have a look at this and fix it, that file editing triggers the new messages to disaply e.g. file watching works.

@felixhaeberle felixhaeberle self-assigned this Mar 11, 2025
@LeBenLeBen
Copy link

Another issue caused by Sherlock keeping translations state in memory: if you change the translation files manually and then extract a new translation, this will override the changes made in the files.

Copy link
Contributor

a fix is coming in opral/monorepo#3494 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants