Support 'readOnly' transactions from Spring Transactional Attributes#8
Open
willks wants to merge 2 commits intoops4j:masterfrom
willks:master
Open
Support 'readOnly' transactions from Spring Transactional Attributes#8willks wants to merge 2 commits intoops4j:masterfrom willks:master
willks wants to merge 2 commits intoops4j:masterfrom
willks:master
Conversation
added 2 commits
May 25, 2015 13:50
…t like there is a running transaction except begin/commit/rollback actions will have no effect
…guard to ensure that resource exists before a cleanup is attempted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During development with this project, I noticed that new transactions were being opened/committed even if the operation was purely a read transaction. This small change ensures that readonly transactions don't actually open/commit any new transactions - leveraging the 'NoTX' transaction type.