Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub Action to automatically scan for vulnerable dependencies #209

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

kengoon
Copy link
Contributor

@kengoon kengoon commented Oct 3, 2024

fixes #207

@kengoon
Copy link
Contributor Author

kengoon commented Oct 5, 2024

@GrapeBaBa I'm done with the github action, please check it out

@GrapeBaBa
Copy link
Member

@GrapeBaBa I'm done with the github action, please check it out

Many thanks your contribution, my original idea is to use https://github.com/paradigmxyz/op-rs/blob/main/.github/dependabot.yml to automatically upgrade dependencies. Can you research this to see if it can be used for Java projects?

@kengoon
Copy link
Contributor Author

kengoon commented Oct 6, 2024

@GrapeBaBa I'm confused now, but the issue says to scan for vulnerable dependencies and output them. Why not merge this and create a new issue with upgrading the dependencies?

@GrapeBaBa
Copy link
Member

@GrapeBaBa I'm confused now, but the issue says to scan for vulnerable dependencies and output them. Why not merge this and create a new issue with upgrading the dependencies?

Ok, let me try it first to see how long will it run. It may be need long time to check so that we may consider not to trigger it every PR.

@kengoon
Copy link
Contributor Author

kengoon commented Oct 6, 2024

@GrapeBaBa the time can be reduced if you get an API key from here https://nvd.nist.gov/developers/request-an-api-key

@kengoon
Copy link
Contributor Author

kengoon commented Oct 6, 2024

I think 27 mins is a reasonable wait time. Well, getting an API key can drastically reduce the time but it will now introduce rate limits which in my own opinion is not a good thing because that will throw a 403 error and cause the CI to fail.

If this is cool with you, you can merge so I can start working on the dependabot for upgrading dependencies.

@GrapeBaBa
Copy link
Member

I think 27 mins is a reasonable wait time. Well, getting an API key can drastically reduce the time but it will now introduce rate limits which in my own opinion is not a good thing because that will throw a 403 error and cause the CI to fail.

Thanks you very much.

@GrapeBaBa GrapeBaBa merged commit 538d5b0 into optimism-java:main Oct 6, 2024
2 checks passed
@kengoon
Copy link
Contributor Author

kengoon commented Oct 6, 2024

@GrapeBaBa sorry I'm asking so much, can I start working on the upgrade?

@GrapeBaBa
Copy link
Member

@GrapeBaBa sorry I'm asking so much, can I start working on the upgrade?

Yes, feel free to create issues and PRs.

@kengoon
Copy link
Contributor Author

kengoon commented Oct 6, 2024

@GrapeBaBa please my only dust account is not updated with my contributions. Just to know if you are meant to report my contribution as done or it would be done automatically.

@GrapeBaBa
Copy link
Member

@GrapeBaBa please my only dust account is not updated with my contributions. Just to know if you are meant to report my contribution as done or it would be done automatically.

Can you see it right now? I am not quite sure how to operate on only dust.

@kengoon
Copy link
Contributor Author

kengoon commented Oct 7, 2024

@GrapeBaBa it's the application that was accepted and not marked done yet.
How to mark done? Need I operate it? I don't see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a GitHub Action to automatically scan for vulnerable dependencies and output alerts.
2 participants