Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10402] feat: add the ability to build distroless images for optimizely #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FSSDK-10402] feat: add the ability to build distroless images for optimizely #419

wants to merge 1 commit into from

Conversation

yesudeep
Copy link

@yesudeep yesudeep commented Jul 9, 2024 •
edited
Loading

Summary

  • Allow us to customize the image tag so that we can use a custom artifact repository such as the Google Artifact Registry (GAR).
  • Add the ability to build optimizely agent distroless images.
  • Enable the end-user to build the images using potentially more secure alternatives such as podman.

Issues

@yesudeep yesudeep marked this pull request as ready for review July 9, 2024 17:17
@yesudeep yesudeep mentioned this pull request Jul 9, 2024
Open
@yesudeep yesudeep force-pushed the yesudeep/feat/distroless-images branch 4 times, most recently from f043632 to fed0f10 Compare July 10, 2024 06:30
@mikechu-optimizely
Copy link
Contributor

mikechu-optimizely commented Jul 10, 2024 •
edited
Loading

I've created internal ticket FSSDK-10402 to provide review.

@yesudeep yesudeep force-pushed the yesudeep/feat/distroless-images branch from fed0f10 to d6bcdd2 Compare August 4, 2024 20:42
@pulak-opti
Copy link
Contributor

Hi @yesudeep
Thanks for the PR!

Please sign the CLA if not already
https://github.com/optimizely/agent/blob/master/CONTRIBUTING.md

pulak-opti
pulak-opti approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@pulak-opti pulak-opti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yesudeep

Please sign the CLA, then we can merge it. Thanks again

@pulak-opti pulak-opti changed the title feat(#418): add the ability to build distroless images for optimizely [FSSDK-10402] feat: add the ability to build distroless images for optimizely Aug 21, 2024
@yesudeep
Copy link
Author

Namaste @pulak-opti

Thanks for accepting the patch! Sure, I will work on the CLA bit shortly.

Best,
Yesudeep.

@pulak-opti
Copy link
Contributor

pulak-opti commented Aug 28, 2024 •
edited
Loading

Hi @yesudeep
Please rebase your branch and make sure you have signed the CLA. Thank you!

@yesudeep
Copy link
Author

Namaste @pulak-opti we're working on the CLA bit internally. I will let you know when we get a green light.

@yesudeep yesudeep force-pushed the yesudeep/feat/distroless-images branch from d6bcdd2 to 2d5b244 Compare August 29, 2024 02:29
@pulak-opti
Copy link
Contributor

Hi @yesudeep
Any update on the CLA? Thank you!

@yesudeep
Copy link
Author

@pulak-opti still in progress. Thanks for being patient. I will keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pulak-opti pulak-opti pulak-opti approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Distroless images for optimizely agent.
3 participants
@yesudeep @mikechu-optimizely @pulak-opti