[FSSDK-10505] chore: update api level #503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzahidul-opti
changed the title
muzahidul-opti
changed the title
jaeopt
requested changes
Jan 28, 2025
| kotlinOptions { | ||
| jvmTarget = '1.8' | ||
| jvmTarget = '17' |
There was a problem hiding this comment.
I see "sourceCompatibility JavaVersion.VERSION_17" upgraded above. It makes sense aligning them together, but not sure about if this upgrade is safe. We still need support old android devices minSdkVersion = 21+
There was a problem hiding this comment.
Got your point. This PR follows up on the ticket.
To add support for java 17, we need to upgrade mocktio 4+, but mockito 4+ is only supported from api label <24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The "why", or other context.
Test plan
Issues