[FSSDK-9775] Log invalid user attributes #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Nov 21, 2023
OptimizelySDK/Event/EventFactory.cs
Outdated
Comment on lines
201
to
204
| if (Validator.IsUserAttributeValid(userAttribute)) | ||
| { | ||
| var attributeId = config.GetAttributeId(userAttribute.Key); | ||
| if (!string.IsNullOrEmpty(attributeId)) |
There was a problem hiding this comment.
What about switching 204 and 201, so we only log invalid type attributes for attribute ids defined in datafile.
We do not care about types of not-registered attributes.
There was a problem hiding this comment.
Let me know what you think @jaeopt
|
Looks like I'm going to need to work on the C# test app to pass FSC |
jaeopt
requested changes
Nov 22, 2023
| if (notRegisteredAttributeKeys.Count > 0 && !(logger is null)) | ||
| { | ||
| logger.Log(LogLevel.WARN, | ||
| $"User attributes: {string.Join(", ", notRegisteredAttributeKeys.ToArray())} are not supported by the datafile and will not be used."); |
There was a problem hiding this comment.
Not sure if we want to log all these here. I see some clients have 100+ attributes not all registered to us. Each event will dump a bunch of these messages. Let's discuss.
|
This was a spike only Jira ticket. Woops. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues