-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-8581] chore: Prepare for 4.0.0 release #371
Conversation
removed beta tag for NuGet
wwwhyy is this still something I have to do??? *coughs: AI*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a quick thought, shouldn't we need to update the readme file?
That's a good question. What are you and @jaeopt adding/updating to the README.md? |
For mobile suit, sample api and version need to be updated. |
Ah yes. I see you have a version number in the Swift SDK README.md then searching I see that the C# SDK has a version number that's not been updated since 3.2 😬 . I'll update that and the SDK Deployment runbook. Thanks. |
This file needs to be reviewed & updates
This file needs to be reviewed & updates
… mike/prepare-release-4.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We can consider adding a line what his major release about. They can look at the release note, but one line of summary will be helpful. |
bring pre-release beta notes up to the GA version section
What's the copy for the README one-liner addition? Will it age well with the 4.x.x? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nit
Summary
Test plan
Issues