Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing pages UI #19

Merged
merged 51 commits into from
Sep 20, 2024
Merged

Landing pages UI #19

merged 51 commits into from
Sep 20, 2024

Conversation

ngumokenneth
Copy link
Contributor

@ngumokenneth ngumokenneth commented Aug 15, 2024

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra file priv/static/Linux.sh. Please remove.

@jrowah
Copy link
Contributor

jrowah commented Sep 8, 2024

There's an extra file priv/static/Linux.sh. Please remove.
There is an empty Linux.sh file which is the one you see as the extra file, I somehow introduced it with one of my previous commits (6248f3b)
but now although github shows its an empty file, deleting it actually deletes the whole Linux scripts.
I don't get what's going on.

@almirsarajcic
Copy link
Member

almirsarajcic commented Sep 9, 2024

There's an extra file priv/static/Linux.sh. Please remove.

There is an empty Linux.sh file which is the one you see as the extra file, I somehow introduced it with one of my previous commits (6248f3b)
but now although github shows its an empty file, deleting it actually deletes the whole Linux scripts.
I don't get what's going on.

That's because of the case change in the file name.

@almirsarajcic
Copy link
Member

Looks good. We just need to change the IDs of ASCIINEMA recordings after they are done and we can merge this.

@almirsarajcic almirsarajcic merged commit 1cab76a into main Sep 20, 2024
15 checks passed
@almirsarajcic almirsarajcic deleted the tools_scripts branch September 20, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants