Fix #4969: add ability to rename the connection string key. #4972
Conversation
|
@zyhfish I will review this PR further. #4969 is a very rare scenario (ie. encountered once in 6 years) so I am not sure if it makes sense to enhance the framework to support it. The main problem in #4969 is that the framework acts in an unexpected way and provides no feedback... therefore the user has no idea that the connection string name is causing a conflict. #4979 resolves this issue by preventing the application from starting up (which mitigates the stream of exceptions) and provides a useful message in the application Log (/Content/Log) to clearly identify the issue. |
|
My preference is to not include support for obscure scenarios as they tend to complicate application logic and become long term baggage for the framework. The probability of anyone needing to change the name of the "DefaultConnection" is extremely low... and now that #4979 provides more detailed feedback, I do not think it is worthwhile to include this enhancement. So I am going to close this PR. |
No description provided.