v1.8.0 #146
Merged
v1.8.0 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
The warning message displayed is as shown below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #138
Decouple dbt-core and the base adapter and use a stable adapter interface i.e.
dbt-adaptersdatabasekey in profile.yml is still optional for all but one of the dbt-oracle workflows. Withoutdatabasename in profile.yml the generated catalog used for project documentation will be empty.Prior dbt 1.8, we could inject
databasename in the manifest because of only dependency ondbt-core. From dbt-oracle 1.8, the adapter can use only the stable interface i.e.dbt-adapters. Catalog generation task is implemented indbt-coreand it seems difficult to injectdatabaseat runtime. There is no way to override a function indbt-core. Adapters should not in any way refer todbt-core.For now, to circumvent the problem, I detect that
databasekey is missing from profile.yml and issue a warning message to the user to add an entry in profile.yml for catalog generation The warning message also shows the database name that dbt-oracle expects. That way users don't have to worry about "what" thedatabasename is and "how" to get it.