Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7 backports #148

Merged
merged 2 commits into from
Jul 2, 2024
Merged

1.7 backports #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b096f
Fix ORA-12098: cannot comment on the materialized view
aosingh Jul 1, 2024
bf5e717
Upgraded version to 1.7.7
aosingh Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Configuration variables
VERSION=1.7.6
VERSION=1.7.7
PROJ_DIR?=$(shell pwd)
VENV_DIR?=${PROJ_DIR}/.bldenv
BUILD_DIR=${PROJ_DIR}/build
Expand Down
2 changes: 1 addition & 1 deletion dbt/adapters/oracle/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
See the License for the specific language governing permissions and
limitations under the License.
"""
version = "1.7.16"
version = "1.7.17"
4 changes: 4 additions & 0 deletions dbt/include/oracle/macros/adapters.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,12 @@

{% macro oracle__alter_relation_comment(relation, comment) %}
{% set escaped_comment = oracle_escape_comment(comment) %}
{% if relation.type == 'materialized_view' %}
comment on materialized view {{ relation }} is {{ escaped_comment }}
{% else %}
{# "comment on table" even for views #}
comment on table {{ relation }} is {{ escaped_comment }}
{% endif %}
{% endmacro %}

{% macro oracle__persist_docs(relation, model, for_relation, for_columns) -%}
Expand Down
2 changes: 1 addition & 1 deletion dbt_adbs_test_project/models/sales_internet_mv.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
See the License for the specific language governing permissions and
limitations under the License.
#}
{{ config(materialized='materialized_view')}}
{{ config(materialized='materialized_view', persist_docs={"relation": true, "columns": true}) }}
select * from {{ source('sh_database', 'sales') }}
where channel_id = 5
3 changes: 3 additions & 0 deletions dbt_adbs_test_project/models/schema.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ sources:
- name: costs

models:
- name: sales_internet_mv
description: Test comment for Materialized View

- name: kafka
description: kafka_description
config:
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = dbt-oracle
version = 1.7.6
version = 1.7.7
description = dbt (data build tool) adapter for Oracle Autonomous Database
long_description = file: README.md
long_description_content_type = text/markdown
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@

url = 'https://github.com/oracle/dbt-oracle'

VERSION = '1.7.6'
VERSION = '1.7.7'
setup(
author="Oracle",
python_requires='>=3.8',
Expand Down
Loading