[GR-62356] Replace ASM with ClassFile API #10758
Open
+1,409
−1,995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@liach could you please review this PR and see if there is anything that can be improved? |
liach
reviewed
Feb 25, 2025
.../src/jdk.graal.compiler.test/src/jdk/graal/compiler/core/test/CustomizedBytecodePattern.java
Outdated
Show resolved
Hide resolved
liach
reviewed
Feb 25, 2025
compiler/src/jdk.graal.compiler.test/src/jdk/graal/compiler/core/test/DynamicConstantTest.java
Outdated
Show resolved
Hide resolved
liach
reviewed
Feb 25, 2025
compiler/src/jdk.graal.compiler.test/src/jdk/graal/compiler/core/test/DynamicConstantTest.java
Outdated
Show resolved
Hide resolved
liach
reviewed
Feb 26, 2025
| .trying(tryBlock -> { | ||
| tryBlock | ||
| .iload(1) | ||
| .invokestatic(classSharedExceptionHandlerClass, "foo", MethodTypeDesc.of(CD_int, CD_int)) |
There was a problem hiding this comment.
You can cache this MethodTypeDesc in a variable and reuse that variable. MethodTypeDesc caches its descriptor string, so reusing the same instance is actually helpful to the ClassFile API's generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces ASM usage with ClassFile API in Graal unit tests. There are three kind of usages:
CustomizedBytecodePatternTestis now an interface and allows multiple definition in subclass, see jdk.graal.compiler.core.test.ResolveDynamicConstantTest