[GR-53985] Add classloader awareness for ClassForNameSupport. #9893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass#forName use in DefaultMBeanServerInterceptor#isInstanceOf
…REGISTRY entries on cleanup When tests are run with c.o.s.enterprise.test.runner.UnitTests (svmtest) all test classes are loaded by NativeImageClassLoader and that loader instance is used throughout all the subsequent image builds that happen as part of a UnitTests run. Entries into ResolvedDispatch#REGISTRY are put there by static initializers of generated classes. Because of the NativeImageClassLoader reuse for all image builds this only happens once per such class and removing the entries on TruffleBaseFeature#cleanup would make them unavailable in a subsequent tests that also rely on the entries in ResolvedDispatch#REGISTRY.
oracle-contributor-agreement
bot
added
the
OCA Verified
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
Class.forName(...)in NI is implemented naively.This prevents us from being able to support reflective class lookup for different classes with equal FQN name.
This PR modifies NI ClassForNameSupport to behave as close as possible to regular Java.