Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OKE OSS Release 1.26.4 #469

Merged
merged 21 commits into from
Jul 4, 2024
Merged

OKE OSS Release 1.26.4 #469

merged 21 commits into from
Jul 4, 2024

Conversation

YashwantGohokar
Copy link
Member

Summary of Changes:

  • Added wait in volume expansion for volume to become available
  • fix security list rule clean up flow for OCI loadbalancer delete calls
  • for externalTrafficPolicy local the healthcheck port security rule should be retained
  • skip healthcheck port in use for services that are deleted or not of type loadbalancer
  • Added fix to check length of consistent device paths available before attempting read
  • process updateLoadbalancer if NLB is in failed state
  • Fix CVEs
  • Separating UpdateLoadBalancer flow for Backends from Ensure Load Balancer flow in CCM
  • Moved listener and backendset updates before shape change & other customer error prone operations
  • Changes to parallelise e2e test runs
  • add opc-retry-token
  • Do not record events for failure to acquire lock for lb sync
  • Add unit test to for merging common tags tags at the time of creation of LB & storage resources
  • Use topology.kubernetes.io labels
  • set serviceUid as opc-retry-token
  • Bugfix: Ensure backend ssl certificates during Update LoadBalancer Backendsets flow
  • Fix response when no size change in ControllerExpandVolume
  • Avoid change service type in update shape test cases
  • List instances to check for authorization issues

dhananjay-ng and others added 14 commits July 1, 2024 12:52
@dhananjay-ng @YashwantGohokar
Added wait in volume expansion for volume to become available
7364777
@pranavsriram8 @YashwantGohokar
fix security list rule clean up flow for OCI loadbalancer delete calls
f66facb
@pranavsriram8 @YashwantGohokar
for externalTrafficPolicy local the healthcheck port security rule sh…
ed7ffca 
…ould be retained
@pranavsriram8 @YashwantGohokar
skip healthcheck port in use for services that are deleted or not of …
69791be 
…type loadbalancer
@dhananjay-ng @YashwantGohokar
Added fix to check length of consistent device paths available before…
031fb51 
… attempting read
@pranavsriram8 @YashwantGohokar
process updateLoadbalancer if NLB is in failed state
0875631
@l-technicore @YashwantGohokar
Separating UpdateLoadBalancer flow for Backends from Ensure Load Bala…
507ad4a 
…ncer flow in CCM

Moved listener and backendset updates before shape change & other customer error prone operations
@YashasG98 @YashwantGohokar
Changes to parallelise e2e test runs
c4f8db0
@pranavsriram8 @YashwantGohokar
add opc-retry-token
a1e4af9
@l-technicore @YashwantGohokar
Do not record events for failure to acquire lock for lb sync
bc830b5
@GouthamML @YashwantGohokar
Add unit test to for merging common tags tags at the time of creation…
d94d4c6 
… of LB & storage resources

Merge common free-form & defined tags to LB, NLB & FSS during provision

Squashed commit:
fix not using generics to remove Go >=1.18 dependency
@YashwantGohokar
Use topology.kubernetes.io labels
33c66d4
@pranavsriram8 @YashwantGohokar
set serviceUid as opc-retry-token
70d230b
@l-technicore @YashwantGohokar
Bugfix: Ensure backend ssl certificates during Update LoadBalancer Ba…
7e782f9 
…ckendsets flow
@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

  • yashas

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jul 1, 2024
@coveralls
Copy link

coveralls commented Jul 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9743048717

Details

  • 156 of 608 (25.66%) changed or added relevant lines in 15 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 30.872%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/csi/driver/bv_node.go 0 1 0.0%
pkg/csi/driver/fss_node.go 0 1 0.0%
pkg/oci/client/networking.go 0 1 0.0%
pkg/cloudprovider/providers/oci/load_balancer_security_lists.go 23 26 88.46%
pkg/cloudprovider/providers/oci/load_balancer_spec.go 25 28 89.29%
pkg/csi-util/utils.go 0 17 0.0%
pkg/oci/client/load_balancer.go 0 20 0.0%
pkg/oci/client/network_load_balancer.go 0 21 0.0%
pkg/cloudprovider/providers/oci/instances.go 0 23 0.0%
pkg/oci/client/compute.go 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/csi-util/utils.go 1 6.71%
pkg/cloudprovider/providers/oci/instances.go 1 52.33%
pkg/oci/client/load_balancer.go 2 7.51%
pkg/cloudprovider/providers/oci/load_balancer.go 4 24.33%
Totals Coverage Status
Change from base Build 7929944992: -0.01%
Covered Lines: 4072
Relevant Lines: 13190
💛 - Coveralls

@YashwantGohokar YashwantGohokar changed the title Oke oss releaes 1.26.4 Oke oss release 1.26.4 Jul 1, 2024
@YashwantGohokar YashwantGohokar force-pushed the oke-oss-releaes_1.26.4 branch from 5d514e5 to b06619c Compare July 3, 2024 09:24
@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9775259435

Details

  • 156 of 608 (25.66%) changed or added relevant lines in 15 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 30.87%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/csi/driver/bv_node.go 0 1 0.0%
pkg/csi/driver/fss_node.go 0 1 0.0%
pkg/oci/client/networking.go 0 1 0.0%
pkg/cloudprovider/providers/oci/load_balancer_security_lists.go 23 26 88.46%
pkg/cloudprovider/providers/oci/load_balancer_spec.go 25 28 89.29%
pkg/csi-util/utils.go 0 17 0.0%
pkg/oci/client/load_balancer.go 0 20 0.0%
pkg/oci/client/network_load_balancer.go 0 21 0.0%
pkg/cloudprovider/providers/oci/instances.go 0 23 0.0%
pkg/oci/client/compute.go 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/csi-util/utils.go 1 6.71%
pkg/cloudprovider/providers/oci/instances.go 1 52.33%
pkg/oci/client/load_balancer.go 2 7.51%
pkg/cloudprovider/providers/oci/load_balancer.go 4 24.32%
Totals Coverage Status
Change from base Build 7929944992: -0.01%
Covered Lines: 4072
Relevant Lines: 13191
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9775285195

Details

  • 156 of 608 (25.66%) changed or added relevant lines in 15 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 30.87%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/csi/driver/bv_node.go 0 1 0.0%
pkg/csi/driver/fss_node.go 0 1 0.0%
pkg/oci/client/networking.go 0 1 0.0%
pkg/cloudprovider/providers/oci/load_balancer_security_lists.go 23 26 88.46%
pkg/cloudprovider/providers/oci/load_balancer_spec.go 25 28 89.29%
pkg/csi-util/utils.go 0 17 0.0%
pkg/oci/client/load_balancer.go 0 20 0.0%
pkg/oci/client/network_load_balancer.go 0 21 0.0%
pkg/cloudprovider/providers/oci/instances.go 0 23 0.0%
pkg/oci/client/compute.go 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/csi-util/utils.go 1 6.71%
pkg/cloudprovider/providers/oci/instances.go 1 52.33%
pkg/oci/client/load_balancer.go 2 7.51%
pkg/cloudprovider/providers/oci/load_balancer.go 4 24.32%
Totals Coverage Status
Change from base Build 7929944992: -0.01%
Covered Lines: 4072
Relevant Lines: 13191
💛 - Coveralls

@YashwantGohokar YashwantGohokar force-pushed the oke-oss-releaes_1.26.4 branch from b06619c to 1dbddf3 Compare July 3, 2024 09:38
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jul 3, 2024
@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9775501156

Details

  • 156 of 608 (25.66%) changed or added relevant lines in 15 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 30.87%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/csi/driver/bv_node.go 0 1 0.0%
pkg/csi/driver/fss_node.go 0 1 0.0%
pkg/oci/client/networking.go 0 1 0.0%
pkg/cloudprovider/providers/oci/load_balancer_security_lists.go 23 26 88.46%
pkg/cloudprovider/providers/oci/load_balancer_spec.go 25 28 89.29%
pkg/csi-util/utils.go 0 17 0.0%
pkg/oci/client/load_balancer.go 0 20 0.0%
pkg/oci/client/network_load_balancer.go 0 21 0.0%
pkg/cloudprovider/providers/oci/instances.go 0 23 0.0%
pkg/oci/client/compute.go 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/csi-util/utils.go 1 6.71%
pkg/cloudprovider/providers/oci/instances.go 1 52.33%
pkg/oci/client/load_balancer.go 2 7.51%
pkg/cloudprovider/providers/oci/load_balancer.go 4 24.32%
Totals Coverage Status
Change from base Build 7929944992: -0.01%
Covered Lines: 4072
Relevant Lines: 13191
💛 - Coveralls

@YashwantGohokar YashwantGohokar force-pushed the oke-oss-releaes_1.26.4 branch from 1dbddf3 to fe15a2e Compare July 4, 2024 06:44
@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9789732455

Details

  • 156 of 608 (25.66%) changed or added relevant lines in 15 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 30.87%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/csi/driver/bv_node.go 0 1 0.0%
pkg/csi/driver/fss_node.go 0 1 0.0%
pkg/oci/client/networking.go 0 1 0.0%
pkg/cloudprovider/providers/oci/load_balancer_security_lists.go 23 26 88.46%
pkg/cloudprovider/providers/oci/load_balancer_spec.go 25 28 89.29%
pkg/csi-util/utils.go 0 17 0.0%
pkg/oci/client/load_balancer.go 0 20 0.0%
pkg/oci/client/network_load_balancer.go 0 21 0.0%
pkg/cloudprovider/providers/oci/instances.go 0 23 0.0%
pkg/oci/client/compute.go 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/csi-util/utils.go 1 6.71%
pkg/cloudprovider/providers/oci/instances.go 1 52.33%
pkg/oci/client/load_balancer.go 2 7.51%
pkg/cloudprovider/providers/oci/load_balancer.go 4 24.32%
Totals Coverage Status
Change from base Build 7929944992: -0.01%
Covered Lines: 4072
Relevant Lines: 13191
💛 - Coveralls

@YashwantGohokar YashwantGohokar force-pushed the oke-oss-releaes_1.26.4 branch from fe15a2e to 01a3853 Compare July 4, 2024 06:51
@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9789809280

Details

  • 156 of 608 (25.66%) changed or added relevant lines in 15 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 30.87%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/csi/driver/bv_node.go 0 1 0.0%
pkg/csi/driver/fss_node.go 0 1 0.0%
pkg/oci/client/networking.go 0 1 0.0%
pkg/cloudprovider/providers/oci/load_balancer_security_lists.go 23 26 88.46%
pkg/cloudprovider/providers/oci/load_balancer_spec.go 25 28 89.29%
pkg/csi-util/utils.go 0 17 0.0%
pkg/oci/client/load_balancer.go 0 20 0.0%
pkg/oci/client/network_load_balancer.go 0 21 0.0%
pkg/cloudprovider/providers/oci/instances.go 0 23 0.0%
pkg/oci/client/compute.go 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/csi-util/utils.go 1 6.71%
pkg/cloudprovider/providers/oci/instances.go 1 52.33%
pkg/oci/client/load_balancer.go 2 7.51%
pkg/cloudprovider/providers/oci/load_balancer.go 4 24.32%
Totals Coverage Status
Change from base Build 7929944992: -0.01%
Covered Lines: 4072
Relevant Lines: 13191
💛 - Coveralls

@mrunalpagnis mrunalpagnis self-requested a review July 4, 2024 07:02
mrunalpagnis
mrunalpagnis approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@mrunalpagnis mrunalpagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

l-technicore
l-technicore approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@l-technicore l-technicore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YashwantGohokar YashwantGohokar changed the title Oke oss release 1.26.4 OKE OSS Release 1.26.4 Jul 4, 2024
@YashwantGohokar YashwantGohokar merged commit c0652a7 into oracle:release-1.26 Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-technicore l-technicore l-technicore approved these changes

@mrunalpagnis mrunalpagnis mrunalpagnis approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@YashwantGohokar @coveralls @mrunalpagnis @l-technicore @dhananjay-ng @pranavsriram8 @YashasG98 @GouthamML @AkarshES