Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yutpeng/secondar vnic #476

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

yutpeng
Copy link
Member

@yutpeng yutpeng commented Jul 18, 2024

Add tags to the OpenShift clusters & VNICs.
Add support of secondary VNICs

CCM E2E Tests Passed:
Screenshot 2024-08-08 at 5 32 32 PM

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 18, 2024
@coveralls
Copy link

coveralls commented Jul 18, 2024

Pull Request Test Coverage Report for Build 10311490795

Details

  • 9 of 82 (10.98%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 30.726%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/oci/client/compute.go 0 35 0.0%
pkg/cloudprovider/providers/oci/instances.go 9 47 19.15%
Totals Coverage Status
Change from base Build 9793107988: -0.1%
Covered Lines: 4081
Relevant Lines: 13282

💛 - Coveralls

@yutpeng yutpeng force-pushed the yutpeng/secondar-vnic branch from e3bc230 to 99b809f Compare July 27, 2024 02:18
@yutpeng yutpeng force-pushed the yutpeng/secondar-vnic branch 2 times, most recently from ea8396a to c4ae168 Compare August 4, 2024 23:14
@yutpeng yutpeng marked this pull request as ready for review August 8, 2024 16:45
@yutpeng yutpeng force-pushed the yutpeng/secondar-vnic branch from 3fae048 to 461e4ac Compare August 9, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants