Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Workload Identity as an auth mechanism #31

Closed
wants to merge 1 commit into from
Closed

Add Workload Identity as an auth mechanism #31

wants to merge 1 commit into from

Conversation

rajashekhargundeti
Copy link
Contributor

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 21, 2024
@coveralls
Copy link

coveralls commented May 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9203421910

Details

  • 1 of 60 (1.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-5.6%) to 56.037%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/types/types.go 0 2 0.0%
internal/service/secret_client_factory.go 0 3 0.0%
internal/server/server.go 1 55 1.82%
Totals Coverage Status
Change from base Build 5961221450: -5.6%
Covered Lines: 362
Relevant Lines: 646
💛 - Coveralls

rajashekhargundeti
rajashekhargundeti commented May 21, 2024
View reviewed changes
Copy link
Contributor Author

@rajashekhargundeti rajashekhargundeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This objective isn't implemented:
The provider should accept audience parameter for token generation or to capture a particular token with correct audience from the provided service account token

GettingStarted.md Outdated Show resolved Hide resolved
internal/server/server.go Outdated
&authenticationv1.TokenRequest{
Spec: authenticationv1.TokenRequestSpec{
ExpirationSeconds: &ttl,
Audiences: []string{"oci", "api"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may leave Audiences empty

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@balkrishna93
Copy link
Member

Closing the pull request in favor of #32

@balkrishna93 balkrishna93 deleted the task/OKE-23005 branch December 5, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YashwantGohokar YashwantGohokar YashwantGohokar approved these changes

@balkrishna93 balkrishna93 balkrishna93 approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajashekhargundeti @coveralls @balkrishna93 @YashwantGohokar