Skip to content

add test for PageConfig#isUnreadable() #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

add test for PageConfig#isUnreadable() #4862

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8260d8f
add test for PageConfig#isUnreadable()
vladak Sep 25, 2025
e4194ff
disable testIsUnreadableTrue() on Windows
vladak Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions opengrok-web/src/test/java/org/opengrok/web/PageConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,4 +1032,40 @@ public String getPathInfo() {
env.releaseIndexSearchers();
IOUtils.removeRecursive(env.getDataRootFile().toPath());
}

@ParameterizedTest
@ValueSource(strings = {"main.c", "nonexistent"})
void testIsUnreadableFalse(String fileName) {
HttpServletRequest req = new DummyHttpServletRequest() {
@Override
public String getPathInfo() {
return "mercurial/" + fileName;
}
};

PageConfig cfg = PageConfig.get(req);
assertFalse(cfg.isUnreadable());
}

// File.setReadable() does not change the behavior of File.canRead() on Windows.
@EnabledOnOs({OS.LINUX, OS.MAC, OS.SOLARIS, OS.AIX, OS.OTHER})
@Test
void testIsUnreadableTrue() {
final String relativePath = Path.of("mercurial", "Makefile").toString();
HttpServletRequest req = new DummyHttpServletRequest() {
@Override
public String getPathInfo() {
return relativePath;
}
};

final File file = new File(RuntimeEnvironment.getInstance().getSourceRootPath(), relativePath);
assertTrue(file.exists());
assertTrue(file.setReadable(false, false));
PageConfig cfg = PageConfig.get(req);
assertTrue(cfg.isUnreadable());

// cleanup
assertTrue(file.setReadable(true, false));
}
}
Loading