Add deserialization tests for 4.3 protobufs in Classification #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
pogren
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
looks like straightforward protobuf serialization testing to me. Create the model, train it with some test data, write it out to a test resource. Test is by deserializing the model and by recreating it and make sure both the deserialized and recreated models look the same and give the same results. Repeat. I didn't scrutinize every line of code - but it looks quite regular and straightforward to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #318 adds deserialization tests to Classification.
Motivation
We will support 4.3 protobufs in v5 and need tests to ensure that the upcoming refactors don't break serialization compatibility.