Support index/length args for string passed to String#bytesplice #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
andrykonchin
approved these changes
Sep 20, 2024
rwstauner
force-pushed
the
rwstauner/bytesplice-str-idx-len
branch
from
b6e1c88
to
74b3a42
Compare
andrykonchin
added
the
in-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional args were added in 3.3 to support taking a substring of the provided string argument.
I applied similar logic to the new args as was already present for the receiver and just used them with
str.byteslice. I'm not sure if there's a more efficient way to do it in the java, but this seems to at least produce the correct result.I took the existing specs, duplicated them, and then rearranged the args so that the test applied to the args for the
strarg instead of the receiver string.Closes #3656