Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default port for mutator webhook #107

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: default port for mutator webhook #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/105.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
`kimup-operator` - Now webhook start with default port 9443.
```
2 changes: 1 addition & 1 deletion cmd/operator/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func main() {

ctrl.SetLogger(logrusr.New(log.GetLogger()))

webhook := webhook.NewServer(webhook.Options{})
webhook := webhook.NewServer(webhook.Options{Port: models.MutatorDefaultPort})

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
Scheme: scheme,
Expand Down
4 changes: 2 additions & 2 deletions internal/models/mutator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package models
import "fmt"

var (
MutatorDefaultPort int32 = 8443
MutatorDefaultAddr = fmt.Sprintf(":%d", MutatorDefaultPort)
MutatorDefaultPort int = 9443
MutatorDefaultAddr = fmt.Sprintf(":%d", MutatorDefaultPort)

MutatorWebhookConfigurationName = "kimup-mutator"
MutatorWebhookName = "image-tag.kimup.cloudavenue.io"
Expand Down
2 changes: 1 addition & 1 deletion manifests/operator/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
- --metrics
- --leader-elect
ports:
- containerPort: 8443
- containerPort: 9443
name: webhook-server
protocol: TCP
- containerPort: 9080
Expand Down
2 changes: 1 addition & 1 deletion tools/env-dev/pod-operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
- "--healthz"
- "--leader-elect"
ports:
- containerPort: 8443
- containerPort: 9443
name: webhook-server
protocol: TCP
- containerPort: 9080
Expand Down
Loading