Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

deprecate: deprecate all existing APIs #96

Merged
merged 14 commits into from
Sep 25, 2023
Merged

deprecate: deprecate all existing APIs #96

merged 14 commits into from
Sep 25, 2023

Conversation

Wwwsylvia
Copy link
Member

  1. Deprecate all existing APIs as they have been moved to oras-go
  2. Update README accordingly

Resolve: #95

@Wwwsylvia
deprecate some
d314563 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
deprecate trace
445fa45 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
update README
d795089 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
minor format
c0ef4a9 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
update
8ed30b1 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #96 (aafd9c7) into main (8b76a43) will decrease coverage by 12.59%.
The diff coverage is 64.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##             main      #96       +/-   ##
===========================================
- Coverage   76.86%   64.28%   -12.59%     
===========================================
  Files           8        6        -2     
  Lines         428       28      -400     
===========================================
- Hits          329       18      -311     
+ Misses         77       10       -67     
+ Partials       22        0       -22
Files Changed Coverage Δ
native_store.go 0.00% <0.00%> (-83.34%) ⬇️
trace/trace.go 0.00% <0.00%> (ø)
registry.go 80.00% <80.00%> (-1.25%) ⬇️
file_store.go 100.00% <100.00%> (ø)
memory_store.go 100.00% <100.00%> (ø)
store.go 100.00% <100.00%> (+19.04%) ⬆️

@Wwwsylvia
revise
e5c5b08 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Wwwsylvia
Wwwsylvia commented Sep 22, 2023
View reviewed changes
memory_store.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Sep 22, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
file_store.go Outdated Show resolved Hide resolved
memory_store.go Outdated Show resolved Hide resolved
shizhMSFT
shizhMSFT reviewed Sep 22, 2023
View reviewed changes
file_store.go Outdated Show resolved Hide resolved
@Wwwsylvia
improve README
9a364ce 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
replace
97bf5c6 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
remove internal
ed500c2 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
update docs
5d97555 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
shizhMSFT
shizhMSFT reviewed Sep 22, 2023
View reviewed changes
file_store.go Outdated Show resolved Hide resolved
trace/trace.go Outdated Show resolved Hide resolved
@Wwwsylvia
rename package alias
4aa49a2 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia
go mod
0395ab7 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia
fix
c9181ba 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
shizhMSFT
shizhMSFT reviewed Sep 25, 2023
View reviewed changes
file_store.go Outdated Show resolved Hide resolved
memory_store.go Outdated Show resolved Hide resolved
native_store.go Outdated Show resolved Hide resolved
registry.go Outdated Show resolved Hide resolved
store.go Outdated Show resolved Hide resolved
trace/trace.go Outdated Show resolved Hide resolved
@Wwwsylvia
fix
aafd9c7 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 9299052 into oras-project:main Sep 25, 2023
7 checks passed
@Wwwsylvia Wwwsylvia deleted the depre branch September 25, 2023 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecating APIs
3 participants
@Wwwsylvia @codecov-commenter @shizhMSFT