Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copy): makes copy more efficient #145

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

leonardochaia
Copy link

@leonardochaia leonardochaia commented Sep 26, 2024

What this PR does / why we need it

This PR improves CopyAsync and CopyGraphAsync to include the CopyOptions, inspired from oras-go.

The current implementation:

  1. adds support for CopyOptions events, like OnPreCopy, these were implemented in the form of Action<T>s
  2. adds support for mounting layers from other repositories.

Pending items

  • Concurrency support
  • Fix copy mounting tests
  • Test CopyOptions events

Which issue(s) this PR resolves / fixes

Fixes #50

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@leonardochaia leonardochaia changed the title feat(copy): support mounting existing descriptors from other repos feat(copy): makes copy more efficient Sep 26, 2024
…ries

Signed-off-by: Leonardo Chaia <leonardochaia@protonmail.com>
Signed-off-by: Leonardo Chaia <leonardochaia@protonmail.com>
@leonardochaia
Copy link
Author

This is a work in progress. Seems to be working running locally. Tests are failing and need more work.

Signed-off-by: Leonardo Chaia <leonardochaia@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Copy efficient
1 participant