-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Include java page #452
feature: Include java page #452
Conversation
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
Not sure why spelling is failing on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be vale doesn't handle multiple spellings without a regular expression, no matter, I think the issue will be resolved if you remove github from link text
Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Include in progress java library
Not sure on which version it should be added
The snapshot link goes to the SNAPSHOT package built from main (since we don't have release yet)