Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Include java page #452

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

jonesbusy
Copy link
Contributor

Include in progress java library

Not sure on which version it should be added

Screenshot from 2025-01-16 19-52-33

The snapshot link goes to the SNAPSHOT package built from main (since we don't have release yet)

Screenshot from 2025-01-16 19-58-20

Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy
Copy link
Contributor Author

Not sure why spelling is failing on github

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be vale doesn't handle multiple spellings without a regular expression, no matter, I think the issue will be resolved if you remove github from link text

versioned_docs/version-1.2/client_libraries/java.mdx Outdated Show resolved Hide resolved
jonesbusy and others added 2 commits January 17, 2025 13:18
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou merged commit 1974f17 into oras-project:main Jan 21, 2025
7 checks passed
@jonesbusy jonesbusy deleted the feature/include-java-library branch January 21, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants