Support case sensitive keys #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use different method for escaping JCR names preserving the casing This closes orbinson#31
Passing in one parameter with comma-separation does not work as the key's themselves might contains a comma (which would require additional escaping) As AEM does not allow to use a different parameter name than "item" with its UriTemplate, use that parameter also in the label servlets.
kwin
force-pushed
the
bugfix/support-case-sensitive-keys
branch
from
8df1afd
to
ef27d9f
Compare
|
|
Any chance for having a release with this PR soon? Thanks a lot in advance. |
|
Of course! you mentioned in the issue that you had to do some rework because of an edge case, didn't know you were ready with it ;). I have one more fix that I need to do myself + the PR that I have open and I'll create a release, I'll see if I can get that done this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use different method for escaping JCR names preserving the casing This closes #31