Shop admin liveview polaris #371
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baradoy
commented
Oct 3, 2023
| ## Examples | ||
|
|
||
| <.box border_color="border" border_width="4">Content</.box> | ||
| <.box background="bg-magic-hover" border_radius="full" padding={[xs: "400"]} width="586px">Content</.box> |
There was a problem hiding this comment.
For reactive attributes we could take a different approach of padding-xs="400".
On the one hand, that would require an enumeration of each possible breakpoint for that attribute padding-xs="400" padding-md="600" padding-lg="400" ..., but on the other hand, it allows us to enforce tokens better. attr :padding-xs, :string, values: Space.tokens().
Perhaps a macro that enumerates the attributes for us.
Baradoy
force-pushed
the
shop_admin_liveview_barebones
branch
from
ef2b6dc to
889856e
Compare
Baradoy
force-pushed
the
shop_admin_liveview_polaris
branch
2 times, most recently
from
75278fe to
75da949
Compare
hez
force-pushed
the
shop_admin_liveview_barebones
branch
from
889856e to
0fe058b
Compare
hez
force-pushed
the
shop_admin_liveview_polaris
branch
from
3c23cec to
8b2609a
Compare
hez
force-pushed
the
shop_admin_liveview_barebones
branch
from
0fe058b to
dab8141
Compare
hez
force-pushed
the
shop_admin_liveview_polaris
branch
from
8b2609a to
32c7c18
Compare
hez
force-pushed
the
shop_admin_liveview_polaris
branch
from
32c7c18 to
033e35a
Compare
hez
force-pushed
the
shop_admin_liveview_barebones
branch
from
dab8141 to
c112f5e
Compare
hez
force-pushed
the
shop_admin_liveview_polaris
branch
from
033e35a to
318199f
Compare
hez
force-pushed
the
shop_admin_liveview_barebones
branch
from
c112f5e to
d24ef51
Compare
Tokens are part of the Polaris design system. They enumerate valid values for various options such as colour, border, and spacing. See https://polaris.shopify.com/tokens
…ke box. In some Polaris components, `padding="400"` is translated into `--pc-box-background:var(--p-color-bg-magic-hover);--pc-box-border-radius:var(--p-border-radius-full);--pc-box-padding-xs:var(--p-space-400);--pc-box-padding-block-end-xs:var(--p-space-400);--pc-box-padding-block-start-xs:var(--p-space-400);--pc-box-padding-inline-end-xs:var(--p-space-400);--pc-box-padding-inline-start-xs:var(--p-space-400)`. This adds a tool that makesx that task easier.
Adds the Box component as it is supposed to be a building block for other components. It also turned out to be one of the more complicated components from an attribute perspective.
This is an example of a much simpler component and implementation
This makes importing those files cleaner.
Required adding the ShadowBevel component for support.
hez
force-pushed
the
shop_admin_liveview_polaris
branch
from
318199f to
617a84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the Box and Spinner component from Polaris as Phoenix components.
Box is a complicated component that takes a huge number of attributes.
Spinner on the other hand only takes 3 attributes. This is to demonstrate the difference between those complicated and simple components.
This also adds some of the Polaris Tokens that where relevant to Box. Tokens are part of the Polaris design system the identifies valid values for colours, borders, padding and the like.