Merge pull request #675 from tchak/add-more-deprecations

Add more deprecations
orbitjs · Jul 10, 2019 · 46e0f55 · 46e0f55
2 parents 1891847 + bbcd622
commit 46e0f55
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/packages/@orbit/indexeddb/src/source.ts b/packages/@orbit/indexeddb/src/source.ts
@@ -21,7 +21,7 @@ import Orbit, {
 import { supportsIndexedDB } from './lib/indexeddb';
 import IndexedDBCache, { IndexedDBCacheSettings } from './cache';
 
-const { assert } = Orbit;
+const { assert, deprecate } = Orbit;
 
 export interface IndexedDBSourceSettings extends SourceSettings {
   namespace?: string;
@@ -86,6 +86,11 @@ export default class IndexedDBSource extends Source
     await this._cache.reopenDB();
   }
 
+  closeDB() {
+    deprecate('`closeDB()` must be called as `cache.closeDB()`.');
+    return this.cache.closeDB();
+  }
+
   /////////////////////////////////////////////////////////////////////////////
   // Resettable interface implementation
   /////////////////////////////////////////////////////////////////////////////

diff --git a/packages/@orbit/memory/src/memory-cache.ts b/packages/@orbit/memory/src/memory-cache.ts
@@ -1,4 +1,5 @@
 /* eslint-disable valid-jsdoc */
+import Orbit from '@orbit/core';
 import { clone, Dict } from '@orbit/utils';
 import { Record, RecordIdentity, equalRecordIdentities } from '@orbit/data';
 import {
@@ -8,6 +9,8 @@ import {
 } from '@orbit/record-cache';
 import { ImmutableMap } from '@orbit/immutable';
 
+const { deprecate } = Orbit;
+
 export interface MemoryCacheSettings extends SyncRecordCacheSettings {
   base?: MemoryCache;
 }
@@ -34,6 +37,17 @@ export default class MemoryCache extends SyncRecordCache {
     return this._records[identity.type].get(identity.id);
   }
 
+  records(type: string) {
+    deprecate(
+      '`records(type).get(id)` is deprecated, use `getRecordSync(identity)`.'
+    );
+    return {
+      get: (id: string) => {
+        return this.getRecordSync({ type, id });
+      }
+    };
+  }
+
   getRecordsSync(typeOrIdentities?: string | RecordIdentity[]): Record[] {
     if (Array.isArray(typeOrIdentities)) {
       const records: Record[] = [];