Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Istio adapter template #12

Merged
merged 11 commits into from
Jan 13, 2020
Merged

Custom Istio adapter template #12

merged 11 commits into from
Jan 13, 2020

Conversation

c0c0n3
Copy link
Member

@c0c0n3 c0c0n3 commented Dec 19, 2019 •
edited
Loading

This PR implements #1.

It also brings in cleaner test scripts with a separate _output_ directory and no source config files duplication.

But we get rid of token header removal as it interferes with validation---see #11.

@c0c0n3 c0c0n3 merged commit d2dc5a8 into master Jan 13, 2020
@c0c0n3
Copy link
Member Author

c0c0n3 commented Jan 13, 2020

Note: Crammed PR

This PR also implements #2 and #6.
In fact, in my immense wisdom I decided to use just one dev branch (the horror!) instead of feature branches and then forgot to merge this PR before pushing the implementation of #2 and #6 to dev :-O

This was referenced Jan 13, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c0c0n3