Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for MQTT notification mechanism #770

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pooja1pathak
Copy link
Collaborator

Proposed changes

A way to store data from mqtt queues. Fix for issue #609

Types of changes

What types of changes does your code introduce to the project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the existing tests locally (not just those related to my feature) and there are no errors
  • After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
  • I have updated the RELEASE NOTES
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

github-actions bot commented Aug 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️

Copy link
Member

@c0c0n3 c0c0n3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooja1pathak great work so far, but I'd be even better if we could keep the code a bit cleaner. So I've suggested some minor refactorings...thanks alot!!!

src/server/wsgi.py Outdated Show resolved Hide resolved
src/server/wsgi.py Outdated Show resolved Hide resolved
Copy link
Member

@c0c0n3 c0c0n3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooja1pathak excellent refactoring, thank you a stack!
should we add some tests?

@pooja1pathak
Copy link
Collaborator Author

@c0c0n3 I am not sure about the test cases for this PR. If you have something in mind, then I can work to that.

@c0c0n3
Copy link
Member

c0c0n3 commented Sep 19, 2024

@pooja1pathak maybe you could put together a docker compose file w/ orion (a version that supports mqtt), quantum leap, plus mongo, as a backend for orion, and crate as a backend for quantum leap. Then write a pytest fixture to set up an mqtt sub for quantum leap so that orion can send data to quantum leap over mqtt. Having that in place, you could write simple tests to send an entity to orion and then check the entity data ends up in crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants