-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for MQTT notification mechanism #770
base: master
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pooja1pathak great work so far, but I'd be even better if we could keep the code a bit cleaner. So I've suggested some minor refactorings...thanks alot!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pooja1pathak excellent refactoring, thank you a stack!
should we add some tests?
@c0c0n3 I am not sure about the test cases for this PR. If you have something in mind, then I can work to that. |
@pooja1pathak maybe you could put together a docker compose file w/ orion (a version that supports mqtt), quantum leap, plus mongo, as a backend for orion, and crate as a backend for quantum leap. Then write a pytest fixture to set up an mqtt sub for quantum leap so that orion can send data to quantum leap over mqtt. Having that in place, you could write simple tests to send an entity to orion and then check the entity data ends up in crate. |
Proposed changes
A way to store data from mqtt queues. Fix for issue #609
Types of changes
What types of changes does your code introduce to the project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...